Bug 86460

Summary:

[EFL][DRT] LayoutTestController does not implement applicationCacheDiskUsageForOrigin

Product:

WebKit

Reporter:

Jussi Kukkonen (jku) <jussi.kukkonen>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, mcatanzaro, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

86195

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	gyuyoung.kim: review-

Jussi Kukkonen (jku)

Reported 2012-05-15 03:27:49 PDT

EFL's LayoutTestController should implement applicationCacheDiskUsageForOrigin() so we can unskip http/tests/appcache/origin-usage.html.

Attachments
Patch (5.86 KB, patch) 2012-05-16 02:34 PDT, Jussi Kukkonen (jku)	no flags	Details Formatted Diff Diff
Patch (5.82 KB, patch) 2012-06-04 02:59 PDT, Jussi Kukkonen (jku)	gyuyoung.kim: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jussi Kukkonen (jku)

Comment 1 2012-05-16 02:34:44 PDT

Created attachment 142206 [details] Patch This will not yet compile without patch in bug 86195, marking 'no-review' for now.

Gyuyoung Kim

Comment 2 2012-05-31 17:52:10 PDT

Comment on attachment 142206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142206&action=review Almost looks good to me except for a style nit. > Source/WebKit/efl/ewk/ewk_security_origin.cpp:89 > +uint64_t ewk_security_origin_application_cache_usage_get(const Ewk_Security_Origin *origin) Move '*' operator to data type side.

Chris Dumez

Comment 3 2012-05-31 22:30:53 PDT

Comment on attachment 142206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142206&action=review > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:577 > + long long usage = ewk_security_origin_application_cache_usage_get(securityOrigin); Could be marked as const.

Jussi Kukkonen (jku)

Comment 4 2012-06-04 02:59:22 PDT

Created attachment 145550 [details] Patch

Jussi Kukkonen (jku)

Comment 5 2012-06-04 03:00:50 PDT

(In reply to comment #4) > Created an attachment (id=145550) [details] > Patch Fixes issues from comment 2 and comment 3, rebases to current master.

Chris Dumez

Comment 6 2012-06-04 04:50:32 PDT

Comment on attachment 145550 [details] Patch LGTM.

Gyuyoung Kim

Comment 7 2012-11-16 22:01:52 PST

Comment on attachment 145550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145550&action=review > LayoutTests/platform/efl/Skipped:-168 > -# EFL's LayoutTestController does not implement applicationCacheDiskUsageForOrigin Now we moved this to TestExpectations file. If this patch is still valid, please touch the file. # EFL's TestRunner does not implement applicationCacheDiskUsageForOrigin webkit.org/b/86460 http/tests/appcache/origin-usage.html [ Failure ]

Michael Catanzaro

Comment 8 2017-03-11 10:45:24 PST

Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.

Note You need to log in before you can comment on or make changes to this bug.