Bug 86459

Summary: MediaStream API: Setting onended on a LocalMediaStream triggers an assertion in V8
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch none

Description Tommy Widenflycht 2012-05-15 03:11:34 PDT 
Setting onended on a MediaStream (either remote or created) works just fine.

LocalMediaStream inherits from MediaStream, but only MediaStream have the EventTarget idl attribute. Adding the attribute to LocalMediaStream as well fixes the issue.
Comment 1 Tommy Widenflycht 2012-05-15 03:15:45 PDT 
Created attachment 141907 [details]
Patch
Comment 2 Adam Barth 2012-05-15 10:32:01 PDT 
Comment on attachment 141907 [details]
Patch

Yeah, it's lame that we don't inherit these sorts of attributes.
Comment 3 WebKit Review Bot 2012-05-15 11:14:59 PDT 
Comment on attachment 141907 [details]
Patch

Clearing flags on attachment: 141907

Committed r117102: <http://trac.webkit.org/changeset/117102>
Comment 4 WebKit Review Bot 2012-05-15 11:15:05 PDT 
All reviewed patches have been landed.  Closing bug.