Bug 86456
| Summary: | [EFL] WebKit style should apply to all ewk files but public headers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Thiago Marcos P. Santos <tmpsantos> |
| Component: | WebKit EFL | Assignee: | Thiago Marcos P. Santos <tmpsantos> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | g.czajkowski, gyuyoung.kim, lucas.de.marchi, rakuco, t.morawski |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 84572, 85178 | ||
| Bug Blocks: | |||
Thiago Marcos P. Santos
My preliminary investigation tells that we need to update the port specific rules on checker.py and move the public headers to another folder.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Raphael Kubo da Costa (:rakuco)
Or just add enough logic to the checker to skip some style checks for public headers?
Thiago Marcos P. Santos
(In reply to comment #1)
> Or just add enough logic to the checker to skip some style checks for public headers?
IMO it would need regex support when matching files. I'm going to evaluate tomorrow to check if it's not overkill.
Thiago Marcos P. Santos
"readability/naming" cannot be enabled for ewk/. Even if enable only for the .cpp files, it will still complain about the function names. IMO not much can be done.