Bug 86418

Summary: CSS3's vh attribute is not adjusting while browser resizes
Product: WebKit Reporter: James Kyle <me>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: eric, koivisto, ojan.autocc, udaykiran4u, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jsfiddle.net/JamesKyle/sRYDC/
Attachments:
Description Flags
Proposed patch
none
Patch for landing
none
Patch for landing none

Description James Kyle 2012-05-14 17:36:38 PDT 
Tested on Google Chrome Canary (21.0.1136.0)

New CSS3 values vh & vw (viewport height & width) implemented in a way that only adjust when resizing the browser horizontally not vertically.

This needs further testing to prove its not just Chrome or JSfiddle.net causing the problem.
Comment 1 Uday Kiran 2013-01-31 00:26:19 PST 
Created attachment 185703 [details]
Proposed patch
Comment 2 Antti Koivisto 2013-01-31 12:09:56 PST 
Comment on attachment 185703 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185703&action=review

Looks good otherwise.

> Source/WebCore/ChangeLog:24
> +        (WebCore::RenderBoxModelObject::calculateFillTileSize): Fixed an error in
> +        initial implementation of vw/vh/vmin.

Please file a separate bug for this. You should fix it in a separate patch with a test case.
Comment 3 Uday Kiran 2013-01-31 12:28:09 PST 
Created attachment 185837 [details]
Patch for landing
Comment 4 Uday Kiran 2013-01-31 12:36:05 PST 
Created attachment 185839 [details]
Patch for landing
Comment 5 Uday Kiran 2013-01-31 12:38:10 PST 
(In reply to comment #4)
> Created an attachment (id=185839) [details]
> Patch for landing

Used webkit-patch land-safely incorrectly, first time :) and missed reviewer's name.
Comment 6 WebKit Review Bot 2013-01-31 15:13:38 PST 
Comment on attachment 185839 [details]
Patch for landing

Clearing flags on attachment: 185839

Committed r141492: <http://trac.webkit.org/changeset/141492>
Comment 7 WebKit Review Bot 2013-01-31 15:13:41 PST 
All reviewed patches have been landed.  Closing bug.