Summary: | Move the parts of RunLoopMac.mm that aren't Mac-specific into RunLoopCF.cpp | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | levin+threading, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andy Estes
2012-05-14 16:33:57 PDT
Created attachment 141814 [details]
Patch
Attachment 141814 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/cf/RunLoopCF.cpp:40: Missing space before { [whitespace/braces] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r117018: <http://trac.webkit.org/changeset/117018> (In reply to comment #2) > Attachment 141814 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > Source/WebCore/platform/cf/RunLoopCF.cpp:40: Missing space before { [whitespace/braces] [5] > Total errors found: 1 in 3 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. I think this is a false positive, so I filed <https://bugs.webkit.org/show_bug.cgi?id=86417>. |