RESOLVED FIXED 86411
Move the parts of RunLoopMac.mm that aren't Mac-specific into RunLoopCF.cpp 
https://bugs.webkit.org/show_bug.cgi?id=86411
Summary Move the parts of RunLoopMac.mm that aren't Mac-specific into RunLoopCF.cpp
Andy Estes
Reported 2012-05-14 16:33:57 PDT
Move the parts of RunLoopMac.mm that aren't Mac-specific into RunLoopCF.cpp
Attachments
Patch (16.48 KB, patch)
2012-05-14 17:00 PDT, Andy Estes 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2012-05-14 17:00:18 PDT
Created attachment 141814 [details] Patch
WebKit Review Bot
Comment 2 2012-05-14 17:04:12 PDT
Attachment 141814 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/cf/RunLoopCF.cpp:40: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andy Estes
Comment 3 2012-05-14 17:04:19 PDT
Committed r117018: <http://trac.webkit.org/changeset/117018>
Andy Estes
Comment 4 2012-05-14 17:27:34 PDT
(In reply to comment #2) > Attachment 141814 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > Source/WebCore/platform/cf/RunLoopCF.cpp:40: Missing space before { [whitespace/braces] [5] > Total errors found: 1 in 3 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. I think this is a false positive, so I filed <https://bugs.webkit.org/show_bug.cgi?id=86417>.
Note You need to log in before you can comment on or make changes to this bug.