Bug 86399

Summary: Convert CSS and Parser tests to runs/s tests
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, kling, menard, ojan, paroga, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Converted CSS and Parser tests to use runPerSecond ojan: review+

Ryosuke Niwa
Reported 2012-05-14 13:59:41 PDT
Convert CSS and Parser tests to runs/s tests
Attachments
Converted CSS and Parser tests to use runPerSecond (5.02 KB, patch)
2012-05-14 14:00 PDT, Ryosuke Niwa 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-05-14 14:00:39 PDT
Created attachment 141785 [details] Converted CSS and Parser tests to use runPerSecond
Eric Seidel (no email)
Comment 2 2012-05-14 14:05:47 PDT
I don't understand what this change does. Could you please explain more in teh ChangeLOg?
Ojan Vafai
Comment 3 2012-05-14 14:10:33 PDT
Comment on attachment 141785 [details] Converted CSS and Parser tests to use runPerSecond r=me assuming you add a more descriptive changelog. IMO, reducing bot cycle time is the secondary benefit. The other advantage is that runPerSecond is less likely to degrade overtime as we improve performance on the test.
Ryosuke Niwa
Comment 4 2012-05-14 14:13:40 PDT
(In reply to comment #2) > I don't understand what this change does. Could you please explain more in teh ChangeLOg? Sorry I forgot to mention that this is a follow up to http://trac.webkit.org/changeset/116916. Basically we want to measure performance in runs/s (i.e. function calls per second) instead of ms so that when WebKit gets faster, we can still measure it reliably (e.g. granularity of Date.now() appears to be around 10-50ms) without having to modify tests to make them artificially slower.
Ryosuke Niwa
Comment 5 2012-05-14 14:19:00 PDT
Committed r117001: <http://trac.webkit.org/changeset/117001>
Note You need to log in before you can comment on or make changes to this bug.