Summary: | Pagination splits lines that could fit on a single page if it were not for their top leading | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||
Component: | Layout and Rendering | Assignee: | mitz | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, dglazkov, eric, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 86445 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
mitz
2012-05-14 11:58:39 PDT
Created attachment 141764 [details]
Make tall lines split in the top leading so that the visible content fits on a single page
Comment on attachment 141764 [details] Make tall lines split in the top leading so that the visible content fits on a single page View in context: https://bugs.webkit.org/attachment.cgi?id=141764&action=review Looks good. > Source/WebCore/ChangeLog:10 > + When a lineâs visible content fits on a page, but adding the top leading makes it taller than Bad quote mark? (In reply to comment #3) > > + When a lineâs visible content fits on a page, but adding the top leading makes it taller than > > Bad quote mark? No, this is bug 75394. I wish I knew how to fix it. Thanks for the review! Comment on attachment 141764 [details] Make tall lines split in the top leading so that the visible content fits on a single page Attachment 141764 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12684467 New failing tests: fast/multicol/split-in-top-margin.html Created attachment 141770 [details]
Archive of layout-test-results from ec2-cr-linux-01
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
(In reply to comment #5) > (From update of attachment 141764 [details]) > Attachment 141764 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/12684467 > > New failing tests: > fast/multicol/split-in-top-margin.html I am going to switch the test to using Ahem. Fixed in <http://trac.webkit.org/r116986> |