Bug 86371

Summary:

Web Inspector: do not update $0-$4 console variables for the objects from loaded from file heap snapshot.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Description Ilya Tikhonovsky 2012-05-14 07:37:46 PDT

%subj%

Comment 1 Ilya Tikhonovsky 2012-05-14 09:19:10 PDT

Created attachment 141739 [details]
Patch

Comment 2 Yury Semikhatsky 2012-05-14 09:56:48 PDT

Comment on attachment 141739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141739&action=review

> Source/WebCore/inspector/front-end/ProfilesPanel.js:278
> +        temporaryProfile._fromFile = true;

Why not have WebInspector.ProfileHeader.prototype.loadFromFile do this?

Comment 3 Ilya Tikhonovsky 2012-05-14 10:11:26 PDT

Committed r116959: <http://trac.webkit.org/changeset/116959>