Bug 86371 - Web Inspector: do not update $0-$4 console variables for the objects from loaded from file heap snapshot.
Summary: Web Inspector: do not update $0-$4 console variables for the objects from loa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-14 07:37 PDT by Ilya Tikhonovsky
Modified: 2012-05-14 10:11 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.72 KB, patch)
2012-05-14 09:19 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-05-14 07:37:46 PDT 
%subj%
Comment 1 Ilya Tikhonovsky 2012-05-14 09:19:10 PDT 
Created attachment 141739 [details]
Patch
Comment 2 Yury Semikhatsky 2012-05-14 09:56:48 PDT 
Comment on attachment 141739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141739&action=review

> Source/WebCore/inspector/front-end/ProfilesPanel.js:278
> +        temporaryProfile._fromFile = true;

Why not have WebInspector.ProfileHeader.prototype.loadFromFile do this?
Comment 3 Ilya Tikhonovsky 2012-05-14 10:11:26 PDT 
Committed r116959: <http://trac.webkit.org/changeset/116959>