Summary: | [EFL] API for PageGroup visited links hash populating | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||
Component: | WebKit EFL | Assignee: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 82579 | ||||||||
Attachments: |
|
Description
Mikhail Pozdnyakov
2012-05-14 07:20:25 PDT
Created attachment 141921 [details]
patch
Comment on attachment 141921 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review > Source/WebKit/efl/ChangeLog:9 > + persistent history storage to fill the visited links cache; what is ; at cache; ? > Source/WebKit/efl/ewk/ewk_view.cpp:1635 > +Eina_Bool ewk_view_add_visited_link(Evas_Object* ewkView, const char* visitedUrl) Style nit : Is ewk_view_visited_link_add better? Comment on attachment 141921 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review Is this patch's test cases covered by Bug 82579 ? > Source/WebKit/efl/ewk/ewk_view.h:1049 > +EAPI Eina_Bool ewk_view_add_visited_link(Evas_Object *o, const char *visited_url); Do not two spaces in front of const keyword. (In reply to comment #3) > (From update of attachment 141921 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review > > Is this patch's test cases covered by Bug 82579 ? > Yes. This bug is enabler for 82579 which is responsible for DRT part. Created attachment 143541 [details]
patch v2 (fixed review comments)
(In reply to comment #2) > (From update of attachment 141921 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review > > > Source/WebKit/efl/ChangeLog:9 > > + persistent history storage to fill the visited links cache; > > what is ; at cache; ? > > > Source/WebKit/efl/ewk/ewk_view.cpp:1635 > > +Eina_Bool ewk_view_add_visited_link(Evas_Object* ewkView, const char* visitedUrl) > > Style nit : Is ewk_view_visited_link_add better? Fixed all above. Thanks for review. Looks good to me now. Comment on attachment 143541 [details] patch v2 (fixed review comments) Clearing flags on attachment: 143541 Committed r118491: <http://trac.webkit.org/changeset/118491> All reviewed patches have been landed. Closing bug. |