Bug 86351

Summary: [Qt] Missing tests for the evaluateJavaScript API
Product: WebKit Reporter: Alexander Færøy <ahf>
Component: WebKit QtAssignee: Alexander Færøy <ahf>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, menard, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kenneth: review+

Alexander Færøy
Reported 2012-05-14 03:55:56 PDT
We need more tests!
Attachments
Patch (4.98 KB, patch)
2012-05-22 06:27 PDT, Alexander Færøy 		no flags
DetailsFormatted DiffDiff
Patch (5.66 KB, patch)
2012-05-23 04:45 PDT, Alexander Færøy 		kenneth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Færøy
Comment 1 2012-05-22 06:27:12 PDT
Created attachment 143293 [details] Patch
Caio Marcelo de Oliveira Filho
Comment 2 2012-05-22 07:48:05 PDT
Comment on attachment 143293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143293&action=review Looks good to me with a few of comments. > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:88 > + messageSpy.clear() The init() function should be clearing this for us already. > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:97 > + webView.resultReceived() Could we get rid of resultReceived and make the spy look at lastResultChanged signal? > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:98 > + }); Try to be consistent about semicolons.
Alexander Færøy
Comment 3 2012-05-23 04:45:54 PDT
Created attachment 143531 [details] Patch
Kenneth Rohde Christiansen
Comment 4 2012-05-23 04:54:56 PDT
Comment on attachment 143531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143531&action=review > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:132 > + compare(webView.lastResult, 1337) float?
Alexander Færøy
Comment 5 2012-05-23 05:14:48 PDT
Committed r118163: <http://trac.webkit.org/changeset/118163>
Note You need to log in before you can comment on or make changes to this bug.