Bug 86331

Summary: [GStreamer] build a static list of mime-types
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: New BugsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, gustavo, menard, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrobinson: review+, buildbot: commit-queue-

Philippe Normand
Reported 2012-05-13 21:21:55 PDT
[GStreamer] build a static list of mime-types
Attachments
Patch (12.34 KB, patch)
2012-05-13 21:27 PDT, Philippe Normand 		mrobinson: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2012-05-13 21:27:30 PDT
Created attachment 141632 [details] Patch
Build Bot
Comment 2 2012-05-13 21:48:51 PDT
Comment on attachment 141632 [details] Patch Attachment 141632 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12682298
Martin Robinson
Comment 3 2012-05-14 08:23:07 PDT
Comment on attachment 141632 [details] Patch One question I have is whether all systems support the codec installer? For instance, if on Windows or some Nokia device, it's unsupported it might better to keep looking at the caps. Perhaps a USE(GSTREAMER_CODEC_INSTALLER) flag or something like that.
Philippe Normand
Comment 4 2012-05-14 09:14:56 PDT
(In reply to comment #3) > (From update of attachment 141632 [details]) > One question I have is whether all systems support the codec installer? For instance, if on Windows or some Nokia device, it's unsupported it might better to keep looking at the caps. Perhaps a USE(GSTREAMER_CODEC_INSTALLER) flag or something like that. Well, we're not there yet and the patch doesn't change the behavior of the player, it can be seen as a refactoring I guess :) All the typefinders are shipped in gst-plugins-base AFAIK. So if we take the example of a device not having a matroska demuxer or VP8 decoder and with the current code video/webm will still be advertized as MayBeSupported. Then if the device's OS supports the codec installer or not is a different matter I think.
Martin Robinson
Comment 5 2012-05-15 11:53:04 PDT
Comment on attachment 141632 [details] Patch Okay. I like hope this simplifies things greatly, but we should be very cautious that this does not cause regressions that make UI clunkier.
Martin Robinson
Comment 6 2012-05-15 11:53:54 PDT
Comment on attachment 141632 [details] Patch Also, before landing please ensure that the HTML5 score is the same before and after this patch.
Philippe Normand
Comment 7 2012-05-15 19:54:42 PDT
Committed r117207: <http://trac.webkit.org/changeset/117207>
Note You need to log in before you can comment on or make changes to this bug.