Summary: | Styles are not recalculated when the seamless attribute is dynamically added/removed | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | pimvdb | ||||||||
Component: | Frames | Assignee: | Eric Seidel (no email) <eric> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, jamesr, jchaffraix, kling, koivisto, ojan, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 45950 | ||||||||||
Attachments: |
|
Description
pimvdb
2012-05-13 02:14:16 PDT
Created attachment 141601 [details]
Test case - main page
Created attachment 141602 [details]
Test case - iframe page
This sounds like two (great) bugs. I'm working on bug #1 now. We'll have to split this bug into two to solve both. Bug #2 is not actually a bug in the code, but a bug in your test. :) The body { } selector is inherited by the child iframe, so even though you change the color on the outer body, it will not be changed on the inner body, since a more specific selector applies. :) Created attachment 141826 [details]
Patch
Thank you for the great bug! I look forward to many more. :) The layout changes for seamless should land in the next couple days, at which point it should begin being actually useful. :) Right now we have only landed the style inheritance, stylesheet inheritance, and navigational changes. The dynamic sizing/layout code will be in my next patch. I've heard that Antti and Kling are perhaps familiar with the world of style as well. :) Comment on attachment 141826 [details]
Patch
Looks fabulous, r=me
Comment on attachment 141826 [details] Patch Clearing flags on attachment: 141826 Committed r117026: <http://trac.webkit.org/changeset/117026> All reviewed patches have been landed. Closing bug. Whoops, bug #2 is indeed my own fault. Sorry about that. Thanks for the very quick response and patch. |