Summary: | [Texmap] TextureMapperAnimations does not support keyframe with multiple animations | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Igor Trindade Oliveira <igor.oliveira> | ||||||||
Component: | WebCore Misc. | Assignee: | Igor Trindade Oliveira <igor.oliveira> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | mrobinson, noam, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Igor Trindade Oliveira
2012-05-12 13:50:27 PDT
Created attachment 141584 [details]
Patch
Proposed patch.
Comment on attachment 141584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141584&action=review > Source/WebCore/ChangeLog:18 > + [Texmap] TextureMapperAnimations does not support keyframe with multiple animations > + https://bugs.webkit.org/show_bug.cgi?id=86303 > + > + Reviewed by NOBODY (OOPS!). > + > + * platform/graphics/texmap/TextureMapperAnimation.cpp: > + (WebCore::TextureMapperAnimations::hasActiveAnimationsOfType): > + (WebCore::TextureMapperAnimations::hasRunningAnimations): > + (WebCore::TextureMapperAnimations::add): > + (WebCore): > + (WebCore::TextureMapperAnimations::pause): > + (WebCore::TextureMapperAnimations::apply): > + * platform/graphics/texmap/TextureMapperAnimation.h: > + (TextureMapperAnimations): Use HashMap<String, Vector<TextureMapperAnimation> >, > + so we can support an keyframe with multiple animations. > + Insufficient changelog. Created attachment 141595 [details]
Patch
Patch V2. Changelog improved.
Comment on attachment 141595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141595&action=review LGTM, except for some renames > Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp:185 > + const Vector<TextureMapperAnimation>& animation = it->second; animation -> animations > Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp:198 > + const Vector<TextureMapperAnimation>& animation = it->second; ditto Created attachment 141607 [details]
Final patch
Comment on attachment 141607 [details] Final patch Clearing flags on attachment: 141607 Committed r116899: <http://trac.webkit.org/changeset/116899> All reviewed patches have been landed. Closing bug. |