Bug 86303 – [Texmap] TextureMapperAnimations does not support keyframe with multiple animations

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Igor Trindade Oliveira]

TextureMapperAnimations uses HashMap<String, TextureMapperAnimation> to store the keyframes animation info, however one keyframe can have more than one animation.

[Igor Trindade Oliveira]

Created attachment 141584 [details]
Patch

Proposed patch.

[Noam Rosenthal]

Comment on attachment 141584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141584&action=review

> Source/WebCore/ChangeLog:18
> +        [Texmap] TextureMapperAnimations does not support keyframe with multiple animations
> +        https://bugs.webkit.org/show_bug.cgi?id=86303
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * platform/graphics/texmap/TextureMapperAnimation.cpp:
> +        (WebCore::TextureMapperAnimations::hasActiveAnimationsOfType):
> +        (WebCore::TextureMapperAnimations::hasRunningAnimations):
> +        (WebCore::TextureMapperAnimations::add):
> +        (WebCore):
> +        (WebCore::TextureMapperAnimations::pause):
> +        (WebCore::TextureMapperAnimations::apply):
> +        * platform/graphics/texmap/TextureMapperAnimation.h:
> +        (TextureMapperAnimations): Use HashMap<String, Vector<TextureMapperAnimation> >,
> +        so we can support an keyframe with multiple animations.
> +

Insufficient changelog.

[Igor Trindade Oliveira]

Created attachment 141595 [details]
Patch

Patch V2. Changelog improved.

[Noam Rosenthal]

Comment on attachment 141595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141595&action=review

LGTM, except for some renames

> Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp:185
> +        const Vector<TextureMapperAnimation>& animation = it->second;

animation -> animations

> Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp:198
> +        const Vector<TextureMapperAnimation>& animation = it->second;

ditto

[Igor Trindade Oliveira]

Created attachment 141607 [details]
Final patch

[WebKit Review Bot]

Comment on attachment 141607 [details]
Final patch

Clearing flags on attachment: 141607

Committed r116899: <http://trac.webkit.org/changeset/116899>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.