Bug 86258

Summary: [chromium] Prevent deadlock on CCVideoLayerImpl destruction
Product: WebKit Reporter: Adrienne Walker <enne>
Component: New BugsAssignee: Adrienne Walker <enne>
Severity: Normal CC: cc-bugs, enne, eric.carlson, feature-media-reviews, fischman, jamesr, nduca, scherkus, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Adrienne Walker 2012-05-11 15:23:46 PDT
[chromium] Prevent deadlock on CCVideoLayerImpl destruction
Comment 1 Adrienne Walker 2012-05-11 15:31:22 PDT
Created attachment 141510 [details]
Comment 2 Adrienne Walker 2012-05-11 15:33:24 PDT
jamesr: Your suggestion to use CCLayerTreeHost::acquireLayerTextures to block the compositor thread from using a destroyed provider worked great in the case where you had another commit and much less great when the tree got destroyed and it was unclear whether a client should clear its provider pointer or not.
Comment 3 James Robinson 2012-05-11 15:36:41 PDT
Comment on attachment 141510 [details]

Comment 4 Nat Duca 2012-05-11 15:48:47 PDT
Comment 5 Andrew Scherkus 2012-05-11 16:26:43 PDT
I also sense great win in this patch.
Comment 6 WebKit Review Bot 2012-05-11 19:04:03 PDT
Comment on attachment 141510 [details]

Clearing flags on attachment: 141510

Committed r116833: <http://trac.webkit.org/changeset/116833>
Comment 7 WebKit Review Bot 2012-05-11 19:04:08 PDT
All reviewed patches have been landed.  Closing bug.