Bug 86250

Summary: Convert some MathML layout tests to reftests
Product: WebKit Reporter: Dave Barton <dbarton>
Component: MathMLAssignee: Dave Barton <dbarton>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, fred.wang, jchaffraix, jkjiang, rakuco, rniwa, webkit.review.bot, xun.sun
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dave Barton
Reported 2012-05-11 13:55:13 PDT
Convert some MathML layout tests to reftests
Attachments
Patch (36.80 KB, patch)
2012-05-11 13:57 PDT, Dave Barton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Barton
Comment 1 2012-05-11 13:57:30 PDT
Created attachment 141490 [details] Patch
Ryosuke Niwa
Comment 2 2012-05-11 14:05:15 PDT
Comment on attachment 141490 [details] Patch I guess we can't use xhtml extension for expected files?
Dave Barton
Comment 3 2012-05-11 14:17:21 PDT
I didn't try making the expected files .xhtml. I'd prefer .html going forward, since it's easier to include MathML (HTML5 does the right thing by default for namespaces) and <script>s, etc. We should of course still have some old .xhtml test sources, for users who do (or did) that, but if we can generate results & new tests mostly using .html it seems easier & better. Let me know if you disagree, of course - I am still new.
Ryosuke Niwa
Comment 4 2012-05-11 14:19:36 PDT
Nah, that's fine. In fact, it's probably preferable to fix both HTML and XHTML so that we can make sure their rendering match.
Ryosuke Niwa
Comment 5 2012-05-11 14:19:51 PDT
s/fix/mix/
Eric Seidel (no email)
Comment 6 2012-05-11 14:20:40 PDT
As Dave mentions, html is infinitely easier to use than xhtml. We have bugs in our xhtml/xml handling for both SVG and MathML I'm sure. For those, we'll need those xml tests, but otherwise we should just do html when we can. :)
WebKit Review Bot
Comment 7 2012-05-11 17:41:42 PDT
Comment on attachment 141490 [details] Patch Clearing flags on attachment: 141490 Committed r116829: <http://trac.webkit.org/changeset/116829>
WebKit Review Bot
Comment 8 2012-05-11 17:41:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.