Bug 86233

Summary: Remove bbox caching from SVGPathElement
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: SVGAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zimmermann: review+

Description Rob Buis 2012-05-11 10:56:02 PDT
I dont think this code adds much value, as SVGLocatable::getBBox is not used much out there.
Comment 1 Rob Buis 2012-05-11 10:58:04 PDT
Created attachment 141450 [details]
Patch
Comment 2 Rob Buis 2012-05-11 18:29:51 PDT
I ran run-perf-tests on the svg PageLoad performance tests and there were no speed regressions there (makes sense since the changed code path is not called by these heavy svg tests). From our layout tests only svg/custom/getBBox-path.svg uses it, and there it is only asked once, so caching is not useful for this test. So overall I think the benefits outweigh the drawbacks of removing this caching, I just don't see this as a hot code path.
Comment 3 Nikolas Zimmermann 2012-05-19 08:23:53 PDT
Comment on attachment 141450 [details]
Patch

Good idea, this was more beneficial in the past where renderers grabbed bounds using getBBox().
Comment 4 Rob Buis 2012-05-19 13:55:24 PDT
Committed r117696: <http://trac.webkit.org/changeset/117696>