| Summary: | Remove RenderLayer::m_scrollOverflow | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> | ||||
| Component: | Layout and Rendering | Assignee: | Julien Chaffraix <jchaffraix> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | enne, eric, jamesr, simon.fraser, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 141440 [details]
Proposed removal 1.
Comment on attachment 141440 [details] Proposed removal 1. Clearing flags on attachment: 141440 Committed r116790: <http://trac.webkit.org/changeset/116790> All reviewed patches have been landed. Closing bug. |
m_scrollOverflow is used in only 1 place: IntSize scrolledContentOffset() const { return scrollOffset() + m_scrollOverflow; } m_scrollOverflow is always set to the opposite of scrollOrigin in computeScrollDimensions() and the previous function is basically returning m_scrollOffset as RenderLayer::scrollOffset() adds scrollOrigin() to m_scrollOffset. Let's kill this confusing variable.