Bug 86226

Summary: Remove RenderLayer::m_scrollOverflow
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Severity: Normal CC: enne, eric, jamesr, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Proposed removal 1. none

Description Julien Chaffraix 2012-05-11 10:21:06 PDT
m_scrollOverflow is used in only 1 place:

IntSize scrolledContentOffset() const { return scrollOffset() + m_scrollOverflow; }

m_scrollOverflow is always set to the opposite of scrollOrigin in computeScrollDimensions() and the previous function is basically returning m_scrollOffset as RenderLayer::scrollOffset() adds scrollOrigin() to m_scrollOffset.

Let's kill this confusing variable.
Comment 1 Julien Chaffraix 2012-05-11 10:31:24 PDT
Created attachment 141440 [details]
Proposed removal 1.
Comment 2 WebKit Review Bot 2012-05-11 11:47:37 PDT
Comment on attachment 141440 [details]
Proposed removal 1.

Clearing flags on attachment: 141440

Committed r116790: <http://trac.webkit.org/changeset/116790>
Comment 3 WebKit Review Bot 2012-05-11 11:47:42 PDT
All reviewed patches have been landed.  Closing bug.