Bug 86218

Summary: Two of the touch-adjustment tests are flaky
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: tdanderson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85101    
Attachments:
Description Flags
Patch
none
Patch none

Allan Sandfeld Jensen
Reported 2012-05-11 08:09:52 PDT
Two of the tests was depending too much on text-size. They should be adjusted so they will give consistent results within the margin of error fonts have between platforms.
Attachments
Patch (5.76 KB, patch)
2012-05-11 08:12 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (4.07 KB, patch)
2012-05-14 09:44 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-05-11 08:12:48 PDT
Created attachment 141421 [details] Patch
Simon Hausmann
Comment 2 2012-05-11 08:21:12 PDT
Comment on attachment 141421 [details] Patch rs=me
WebKit Review Bot
Comment 3 2012-05-11 09:32:55 PDT
Comment on attachment 141421 [details] Patch Clearing flags on attachment: 141421 Committed r116777: <http://trac.webkit.org/changeset/116777>
WebKit Review Bot
Comment 4 2012-05-11 09:33:00 PDT
All reviewed patches have been landed. Closing bug.
Allan Sandfeld Jensen
Comment 5 2012-05-14 08:02:34 PDT
Reopening since, touchadjustment/touch-inlines.html is still failing on chromium.
Allan Sandfeld Jensen
Comment 6 2012-05-14 09:44:25 PDT
Created attachment 141742 [details] Patch Fixup
Darin Adler
Comment 7 2012-05-14 10:15:58 PDT
Comment on attachment 141742 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141742&action=review > LayoutTests/touchadjustment/touch-inlines.html:11 > +<p style="width: 22em;"> Why use em units here instead of px?
WebKit Review Bot
Comment 8 2012-05-14 11:18:07 PDT
Comment on attachment 141742 [details] Patch Clearing flags on attachment: 141742 Committed r116972: <http://trac.webkit.org/changeset/116972>
WebKit Review Bot
Comment 9 2012-05-14 11:18:19 PDT
All reviewed patches have been landed. Closing bug.
Allan Sandfeld Jensen
Comment 10 2012-05-14 11:33:03 PDT
(In reply to comment #7) > (From update of attachment 141742 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141742&action=review > > > LayoutTests/touchadjustment/touch-inlines.html:11 > > +<p style="width: 22em;"> > > Why use em units here instead of px? Well, for Ahem it makes it easy to count where the line-break should be since they are square and monotype. The original test was just a partial copy of the text transformation-test in ManualTests/qt.
Note You need to log in before you can comment on or make changes to this bug.