Bug 86211

Summary: Web Inspector: add Profiler.getHeapObjectId command
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, haraken, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 86204    
Attachments:
Description Flags
Patch pfeldman: review+

Description Yury Semikhatsky 2012-05-11 06:46:27 PDT 
We need this command to implement "reveal in heap snapshot" action.
Comment 1 Yury Semikhatsky 2012-05-11 06:48:34 PDT 
Created attachment 141405 [details]
Patch
Comment 2 Pavel Feldman 2012-05-11 07:14:48 PDT 
Comment on attachment 141405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141405&action=review

> Source/WebCore/inspector/Inspector.json:2680
> +                    { "name": "heapSnapshotObjectId", "type": "string", "description": "Heap snapshot object id." }

Please introduce type for the id.

> Source/WebCore/inspector/InspectorProfilerAgent.cpp:455
> +    ScriptValue jsValue = injectedScript.findObjectById(objectId);

jsValue -> value.
Comment 3 Yury Semikhatsky 2012-05-11 07:47:41 PDT 
(In reply to comment #2)
> (From update of attachment 141405 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141405&action=review
> 
> > Source/WebCore/inspector/Inspector.json:2680
> > +                    { "name": "heapSnapshotObjectId", "type": "string", "description": "Heap snapshot object id." }
> 
> Please introduce type for the id.
Done.

> 
> > Source/WebCore/inspector/InspectorProfilerAgent.cpp:455
> > +    ScriptValue jsValue = injectedScript.findObjectById(objectId);
> 
> jsValue -> value.
Done.
Comment 4 Yury Semikhatsky 2012-05-11 08:05:00 PDT 
Committed r116768: <http://trac.webkit.org/changeset/116768>