Bug 86188

Summary: Web Inspector: use div, not span as a parent element for ElementsTreeOutline in Audits panel
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Andrey Kosyakov
Reported 2012-05-11 02:01:39 PDT
This is a follow-up fix for r116739. The audit panel uses span as a container for formatted results, including those produced by node formatter. ElementsTreeOutline needs offsetWidth in treeElementFromEvent(), which is only meaningful for block-level elements (returns 0 for inline).
Attachments
Patch (4.06 KB, patch)
2012-05-11 02:04 PDT, Andrey Kosyakov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2012-05-11 02:04:23 PDT
Created attachment 141358 [details] Patch
Yury Semikhatsky
Comment 2 2012-05-11 02:14:36 PDT
Comment on attachment 141358 [details] Patch We should consider making ElementsTreeOutline element a div.
Andrey Kosyakov
Comment 3 2012-05-11 02:35:13 PDT
Committed r116743: <http://trac.webkit.org/changeset/116743>
Note You need to log in before you can comment on or make changes to this bug.