Bug 86163

Summary:

Simplify FloatingObject by removing unnecessary convenience methods.

Product:

WebKit

Reporter:

Emil A Eklund <eae>

Component:

Layout and Rendering

Assignee:

Emil A Eklund <eae>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, leviw, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none
Patch for landing	none

Emil A Eklund

Reported 2012-05-10 17:14:44 PDT

Simplify the pixel snapping in FloatingObject by getting rid of a bunch of convenience functions.

Attachments
Patch (7.22 KB, patch) 2012-05-10 17:19 PDT, Emil A Eklund	no flags	Details Formatted Diff Diff
Patch for landing (7.25 KB, patch) 2012-05-10 17:41 PDT, Emil A Eklund	no flags	Details Formatted Diff Diff
Patch for landing (7.86 KB, patch) 2012-05-10 17:52 PDT, Emil A Eklund	no flags	Details Formatted Diff Diff
Patch for landing (8.45 KB, patch) 2012-05-11 10:31 PDT, Emil A Eklund	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Emil A Eklund

Comment 1 2012-05-10 17:19:25 PDT

Created attachment 141297 [details] Patch

Eric Seidel (no email)

Comment 2 2012-05-10 17:36:17 PDT

Comment on attachment 141297 [details] Patch Yes, yes yes!

Darin Adler

Comment 3 2012-05-10 17:36:56 PDT

Comment on attachment 141297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141297&action=review > Source/WebCore/ChangeLog:3 > + Simplify FloatingObject API I am not sure that API means what you think it means ;-)

Emil A Eklund

Comment 4 2012-05-10 17:39:09 PDT

> I am not sure that API means what you think it means ;-) Yeah, I agree, not the worded description. I'll update it before committing.

Build Bot

Comment 5 2012-05-10 17:41:07 PDT

Comment on attachment 141297 [details] Patch Attachment 141297 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12676034

Emil A Eklund

Comment 6 2012-05-10 17:41:36 PDT

Created attachment 141299 [details] Patch for landing

Emil A Eklund

Comment 7 2012-05-10 17:52:05 PDT

Created attachment 141302 [details] Patch for landing

WebKit Review Bot

Comment 8 2012-05-10 21:57:00 PDT

Comment on attachment 141302 [details] Patch for landing Rejecting attachment 141302 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: :FloatingObject*>::string(const WebCore::RenderBlock::FloatingObject*)': Source/WebCore/rendering/RenderBlock.cpp:7342: error: 'const struct WebCore::RenderBlock::FloatingObject' has no member named 'pixelSnappedY' Source/WebCore/rendering/RenderBlock.cpp:7342: error: 'const struct WebCore::RenderBlock::FloatingObject' has no member named 'pixelSnappedMaxX' make: *** [out/Debug/obj.target/webcore_rendering/Source/WebCore/rendering/RenderBlock.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/12663565

Emil A Eklund

Comment 9 2012-05-11 10:31:50 PDT

Created attachment 141441 [details] Patch for landing

WebKit Review Bot

Comment 10 2012-05-11 11:20:54 PDT

Comment on attachment 141441 [details] Patch for landing Clearing flags on attachment: 141441 Committed r116788: <http://trac.webkit.org/changeset/116788>

WebKit Review Bot

Comment 11 2012-05-11 11:20:59 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.