Bug 86151

Summary: Reduce GradientAttributes object size
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: SVGAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, rniwa, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2012-05-10 15:47:56 PDT
This can use better bitpacking.
Attachments
Patch (2.16 KB, patch)
2012-05-10 15:54 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (2.73 KB, patch)
2012-08-20 19:36 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2012-05-10 15:54:51 PDT
Created attachment 141283 [details] Patch
Eric Seidel (no email)
Comment 2 2012-08-12 04:30:18 PDT
Comment on attachment 141283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141283&action=review > Source/WebCore/svg/GradientAttributes.h:80 > + unsigned m_spreadMethod : 2; > + unsigned m_gradientUnits : 2; Do we need to add any COMPILE_ASSERTS that these fit in two bits? Will the compiler warn us as-is?
Ryosuke Niwa
Comment 3 2012-08-12 12:51:58 PDT
Comment on attachment 141283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141283&action=review > Source/WebCore/svg/GradientAttributes.h:84 > bool m_spreadMethodSet : 1; > bool m_gradientUnitsSet : 1; We can make these member variables to unsigned and save more space on Windows.
Ryosuke Niwa
Comment 4 2012-08-12 12:51:59 PDT
Comment on attachment 141283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141283&action=review > Source/WebCore/svg/GradientAttributes.h:84 > bool m_spreadMethodSet : 1; > bool m_gradientUnitsSet : 1; We can make these member variables to unsigned and save more space on Windows.
Ryosuke Niwa
Comment 5 2012-08-19 18:37:43 PDT
Has this been landed yet?
Rob Buis
Comment 6 2012-08-20 07:27:53 PDT
(In reply to comment #5) > Has this been landed yet? No, I plan to make some changes and will maybe post again for the final patch.
Rob Buis
Comment 7 2012-08-20 19:36:46 PDT
Created attachment 159593 [details] Patch
WebKit Review Bot
Comment 8 2012-08-20 22:45:59 PDT
Comment on attachment 159593 [details] Patch Clearing flags on attachment: 159593 Committed r126134: <http://trac.webkit.org/changeset/126134>
WebKit Review Bot
Comment 9 2012-08-20 22:46:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.