Bug 86148 – [Qt] Fix build after QPA file renaming

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Donald Carr]

Fixes Webkit to build after:

https://codereview.qt-project.org/#change,23443

[Donald Carr]

Created attachment 141268 [details]
build fix

[WebKit Review Bot]

Attachment 141268 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/plugins/qt/PluginViewQt.cpp:87:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 141268 [details]
build fix

Attachment 141268 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12672096

[Csaba Osztrogonác]

It seems it is what I searched. :) Let me try it.

[Csaba Osztrogonác]

The build works fine, but unfortunately there is a serious regression in Qt5 somewhere, because _all_ tests crash with this backtrace:

$ run-in-xvfb.sh gdb WebKitBuild/Debug/bin/DumpRenderTree

GNU gdb (GDB) 7.0.1-debian
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree...done.

(gdb) run css2.1/t0402-c71-fwd-parsing-00-f.html

Starting program: /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree css2.1/t0402-c71-fwd-parsing-00-f.html
[Thread debugging using libthread_db enabled]

Program received signal SIGABRT, Aborted.
0x00007fffebfe91b5 in *__GI_raise (sig=<value optimized out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
64      ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
        in ../nptl/sysdeps/unix/sysv/linux/raise.c
Current language:  auto
The current source language is "auto; currently c".
(gdb) bt
#0  0x00007fffebfe91b5 in *__GI_raise (sig=<value optimized out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
#1  0x00007fffebfebfc0 in *__GI_abort () at abort.c:92
#2  0x00007fffecfe3c45 in qt_message_output(QtMsgType, QMessageLogContext const&, QString const&) ()
   from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtCore.so.5
#3  0x00007fffecfe41b6 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtCore.so.5
#4  0x00007fffecfe4353 in QMessageLogger::fatal(char const*, ...) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtCore.so.5
#5  0x00007fffed6c9c5d in QGuiApplicationPrivate::createPlatformIntegration() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtGui.so.5
#6  0x00007fffed6cadbd in QGuiApplicationPrivate::createEventDispatcher() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtGui.so.5
#7  0x00007fffed18e00a in QCoreApplication::init() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtCore.so.5
#8  0x00007fffed18e275 in QCoreApplication::QCoreApplication(QCoreApplicationPrivate&) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtCore.so.5
#9  0x00007fffed6cab8d in QGuiApplication::QGuiApplication(QGuiApplicationPrivate&) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtGui.so.5
#10 0x00007fffeed1d6e7 in QApplication::QApplication(int&, char**, int) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r30c/lib/libQtWidgets.so.5
#11 0x000000000042d33a in main (argc=2, argv=0x7fffffffe368) at /home/oszi/WebKit/Tools/DumpRenderTree/qt/main.cpp:152


5146b9449d58b2c3fe54173ebbdfb07b6e0da19f is the latest working Qt5 hash and df4acd4b44261fed883c456b77e442a4234aa746 has this bug. (and the latest 47e8da3a178579ac4c05feb66db9cfafc0fe64d6 has it too)

[Noam Rosenthal]

(In reply to comment #5)
> The build works fine, but unfortunately there is a serious regression in Qt5 somewhere, because _all_ tests crash with this backtrace:
> 
> $ run-in-xvfb.sh gdb WebKitBuild/Debug/bin/DumpRenderTree
> #4  0x00007fffecfe4353 in QMessageLogger::fatal(char const*, ...) () from 

Do we know what the fatal error log actually is?

[Csaba Osztrogonác]

How can I get it?

[Noam Rosenthal]

(In reply to comment #7)
> How can I get it?
It should be in stderr right before the crash.

[Csaba Osztrogonác]

(In reply to comment #8)
> (In reply to comment #7)
> > How can I get it?
> It should be in stderr right before the crash.

I can't find any additionalt error, I copy/pasted the full log.

[Csaba Osztrogonác]

Simon found the culprit, thanks for it: configure disabled XCB because of missing libxcb-randr0-dev package. It is a new dependency for XCB after this qtbase commit: f280efc6201adf8933c9d48a1d5b6983ee9fed9b

I'll rebuild Qt5 again and test WebKit with it.

[Csaba Osztrogonác]

Comment on attachment 141268 [details]
build fix

r=me

[Csaba Osztrogonác]

Comment on attachment 141268 [details]
build fix

Clearing flags on attachment: 141268

Committed r117291: <http://trac.webkit.org/changeset/117291>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.