Bug 86145

Summary: [webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: Tools / TestsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, d-r, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dpranke: review+

Raphael Kubo da Costa (:rakuco)
Reported 2012-05-10 14:11:06 PDT
[webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
Attachments
Patch (3.95 KB, patch)
2012-05-10 14:14 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch (4.33 KB, patch)
2012-05-10 14:37 PDT, Raphael Kubo da Costa (:rakuco) 		dpranke: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-05-10 14:14:05 PDT
Created attachment 141249 [details] Patch
Dirk Pranke
Comment 2 2012-05-10 14:19:57 PDT
Comment on attachment 141249 [details] Patch options are reserved for things that are actually command line flags. Please use a property or method on the object instead.
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-05-10 14:37:37 PDT
Created attachment 141260 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-05-10 14:59:42 PDT
Committed r116692: <http://trac.webkit.org/changeset/116692>
Note You need to log in before you can comment on or make changes to this bug.