Bug 86145 - [webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
Summary: [webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-10 14:11 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-05-10 14:59 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.95 KB, patch)
2012-05-10 14:14 PDT, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Patch (4.33 KB, patch)
2012-05-10 14:37 PDT, Raphael Kubo da Costa (:rakuco)
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-05-10 14:11:06 PDT
[webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-05-10 14:14:05 PDT
Created attachment 141249 [details]
Patch
Comment 2 Dirk Pranke 2012-05-10 14:19:57 PDT
Comment on attachment 141249 [details]
Patch

options are reserved for things that are actually command line flags. Please use a property or method on the object instead.
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-05-10 14:37:37 PDT
Created attachment 141260 [details]
Patch
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-05-10 14:59:42 PDT
Committed r116692: <http://trac.webkit.org/changeset/116692>