Bug 86143

Summary: WK2/Plugins: Move enumeration of plugins to a secondary UIProcess thread.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Plug-insAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, koivisto, levin+threading, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 86378    
Bug Blocks:    
Attachments:
Description Flags
Modest first stab
buildbot: commit-queue-
Patch again
none
Patch
none
Patch
none
Patch none

Andreas Kling
Reported 2012-05-10 14:09:35 PDT
<rdar://problem/10777218>
Attachments
Modest first stab (31.56 KB, patch)
2012-05-10 14:19 PDT, Andreas Kling 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch again (31.70 KB, patch)
2012-05-10 15:06 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (29.21 KB, patch)
2012-05-11 11:10 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (31.75 KB, patch)
2012-05-11 11:12 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (32.12 KB, patch)
2012-05-11 12:41 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2012-05-10 14:19:32 PDT
Created attachment 141254 [details] Modest first stab
WebKit Review Bot
Comment 2 2012-05-10 14:27:30 PDT
Attachment 141254 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/WebContext.h:250: The parameter name "connection" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/WebContext.h:250: The parameter name "messageID" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2012-05-10 14:58:25 PDT
Comment on attachment 141254 [details] Modest first stab Attachment 141254 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12673051
Early Warning System Bot
Comment 4 2012-05-10 15:02:38 PDT
Comment on attachment 141254 [details] Modest first stab Attachment 141254 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12670113
Andreas Kling
Comment 5 2012-05-10 15:06:12 PDT
Created attachment 141274 [details] Patch again Apparently everyone doesn't build on OS X. Crazy.
Andreas Kling
Comment 6 2012-05-11 11:10:39 PDT
Created attachment 141453 [details] Patch Rebased because Anders.
Andreas Kling
Comment 7 2012-05-11 11:12:30 PDT
Created attachment 141454 [details] Patch
Andreas Kling
Comment 8 2012-05-11 12:41:25 PDT
Created attachment 141476 [details] Patch Per AndersCa's request match WebContext's addQueueClient with a removeQueueClient in the destructor.
Andreas Kling
Comment 9 2012-05-11 12:49:06 PDT
Comment on attachment 141476 [details] Patch Clearing flags on attachment: 141476 Committed r116796: <http://trac.webkit.org/changeset/116796>
Andreas Kling
Comment 10 2012-05-11 12:49:18 PDT
All reviewed patches have been landed. Closing bug.
Antti Koivisto
Comment 11 2012-05-14 09:14:25 PDT
Looks like this caused an API test failure, bug 86378.
Note You need to log in before you can comment on or make changes to this bug.