webkit fails IETC namespaces/syntax-021.xml

• Component: CSS
• Status: RESOLVED FIXED

[Dave Tharp]

Filler text has a red background. Expected green.

[Takashi Sakamoto]

Created attachment 142454 [details]
Patch

[WebKit Review Bot]

Comment on attachment 142454 [details]
Patch

Attachment 142454 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12715585

New failing tests:
fast/dom/SelectorAPI/not-supported-namespace-in-selector.html
fast/dom/shadow/content-selector-query.html
fast/css/css-selector-text.html
fast/css/css-set-selector-text.html

[WebKit Review Bot]

Created attachment 142458 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Hajime Morrita]

Comment on attachment 142454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142454&action=review

> LayoutTests/platform/chromium/test_expectations.txt:3618
> +BUGWK86142 : ietestcenter/css3/namespaces/syntax-021.xml = PASS IMAGE

"PASS" is used to mark it flaky.

In this case, you can just add comment that this can be rebaselined then ask someone to rebaseline this.

[Takashi Sakamoto]

Created attachment 146210 [details]
Patch

[Takashi Sakamoto]

Created attachment 146214 [details]
Patch

[Takashi Sakamoto]

(In reply to comment #4)
> (From update of attachment 142454 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142454&action=review
> 
> > LayoutTests/platform/chromium/test_expectations.txt:3618
> > +BUGWK86142 : ietestcenter/css3/namespaces/syntax-021.xml = PASS IMAGE
> 
> "PASS" is used to mark it flaky.
> 
> In this case, you can just add comment that this can be rebaselined then ask someone to rebaseline this.

I see.
As the test passes under chromium, I removed the line from LayoutTests/platform/chromium/TestExpectations.

Talking about fast/css/css-selector-text.html, I found that the test uses undeclared namespace prefix, i.e. n|a, n|*, [n|a], but n is not declared. So I updated the test. 

Best regards,
Takashi Sakamoto

[Takashi Sakamoto]

Created attachment 155742 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 155742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155742&action=review

> Source/WebCore/css/CSSGrammar.y:1127
> +        if (p->isDeclaredNamespacePrefix($3)) {
> +            $$ = p->createFloatingSelector();
> +            $$->setAttribute(p->determineNameInNamespace($3, $4));

Kind of sad that we could end up calling determineNameSpace twice here (once in isDeclaredNamespacePrefix).

[Anders Carlsson]

Comment on attachment 155742 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 316781 [details]
Patch

[Chris Dumez]

Comment on attachment 316781 [details]
Patch

You don't need review for such change but r=me

[Alexey Proskuryakov]

Comment on attachment 316781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316781&action=review

> LayoutTests/ChangeLog:12
> +        * platform/gtk/TestExpectations:

We have this expectation on multiple platforms:

$ find-expectations syntax-021.xml
LayoutTests/platform/gtk/TestExpectations:2622:webkit.org/b/86142 ietestcenter/css3/namespaces/syntax-021.xml [ ImageOnlyFailure ]
LayoutTests/platform/ios-simulator/TestExpectations:58:ietestcenter/css3/namespaces/syntax-021.xml [ ImageOnlyFailure ]
LayoutTests/platform/mac/TestExpectations:543:webkit.org/b/86142 ietestcenter/css3/namespaces/syntax-021.xml [ ImageOnlyFailure ]
LayoutTests/platform/win/TestExpectations:2018:ietestcenter/css3/namespaces/syntax-021.xml [ ImageOnlyFailure ]

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 316837 [details]
Patch

[Build Bot]

Attachment 316837 [details] did not pass style-queue:


ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:3344:  More specific entry for accessibility/heading-crash-after-hidden.html on line LayoutTests/platform/win/TestExpectations:3344 overrides line LayoutTests/platform/win/TestExpectations:1349.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:4005:  More specific entry for http/tests/websocket/tests/hybi/workers/close-code-and-reason.html on line LayoutTests/platform/win/TestExpectations:4005 overrides line LayoutTests/platform/win/TestExpectations:2158.  [test/expectations] [5]
Total errors found: 2 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 316837 [details]
Patch

Rejecting attachment 316837 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 316837, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
den.html on line LayoutTests/platform/win/TestExpectations:3344 overrides line LayoutTests/platform/win/TestExpectations:1349.  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/win/TestExpectations:4005:  More specific entry for http/tests/websocket/tests/hybi/workers/close-code-and-reason.html on line LayoutTests/platform/win/TestExpectations:4005 overrides line LayoutTests/platform/win/TestExpectations:2158.  [test/expectations] [5]
Total errors found: 2 in 0 files

Full output: http://webkit-queues.webkit.org/results/4234479

[Alexey Proskuryakov]

The commit queue failure is clearly wrong, and a regression from running the linter. But also, I'm not sure why it runs the style checker at all in the first place.

[WebKit Commit Bot]

Comment on attachment 316837 [details]
Patch

Clearing flags on attachment: 316837

Committed r220132: <http://trac.webkit.org/changeset/220132>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33678898>

[Jonathan Bedard]

Alexey is right, this is a bug in the style checker, tracked here: <https://bugs.webkit.org/show_bug.cgi?id=175078>.