Bug 175078 - check-webkit-style: deleting lines in a file runs the linter on the whole file
Summary: check-webkit-style: deleting lines in a file runs the linter on the whole file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-02 10:44 PDT by Jonathan Bedard
Modified: 2017-08-02 15:36 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.11 KB, patch)
2017-08-02 10:58 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-08-02 10:44:45 PDT
If we've only removed lines from a file, we will run the linter on the entire file.  This is incorrect.
Comment 1 Jonathan Bedard 2017-08-02 10:50:54 PDT
This was uncovered by <https://bugs.webkit.org/show_bug.cgi?id=86142>.
Comment 2 Jonathan Bedard 2017-08-02 10:58:28 PDT
Created attachment 316974 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2017-08-02 14:56:39 PDT
Comment on attachment 316974 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2017-08-02 15:35:47 PDT
Comment on attachment 316974 [details]
Patch

Clearing flags on attachment: 316974

Committed r220158: <http://trac.webkit.org/changeset/220158>
Comment 5 WebKit Commit Bot 2017-08-02 15:35:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-08-02 15:36:24 PDT
<rdar://problem/33687321>