Summary: | IndexedDB: Index key paths that yield invalid keys should not fail an add/put | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Bell <jsbell> | ||||||
Component: | WebCore Misc. | Assignee: | Joshua Bell <jsbell> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | alecflett, dgrogan, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 86123 | ||||||||
Attachments: |
|
Description
Joshua Bell
2012-05-10 11:49:51 PDT
Created attachment 142814 [details]
Patch
tony@ - r? Comment on attachment 142814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142814&action=review > Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:289 > + indexKeys.append(PassRefPtr<IDBKey>()); Nit: Should this be using a IDBKey::create function? Creating a PassRefPtr explicitly feels weird. Comment on attachment 142814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142814&action=review >> Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:289 >> + indexKeys.append(PassRefPtr<IDBKey>()); > > Nit: Should this be using a IDBKey::create function? Creating a PassRefPtr explicitly feels weird. So does calling release() on a known-empty RefPtr (the previous code). I'll see if I can come up with something cleaner without a big restructure. Created attachment 143065 [details]
Patch for landing
Comment on attachment 143065 [details] Patch for landing Clearing flags on attachment: 143065 Committed r117808: <http://trac.webkit.org/changeset/117808> All reviewed patches have been landed. Closing bug. |