Bug 86106

Summary: Change isBlock and isInline functions to check for isElementNode
Product: WebKit Reporter: Abhishek Arya <inferno>
Component: HTML EditingAssignee: Ahmad Saleem <ahmad.saleem792>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ahmad.saleem792, darin, enrica, inferno, rniwa
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   

Abhishek Arya
Reported 2012-05-10 09:39:09 PDT
This came up in discussion on bug https://bugs.webkit.org/show_bug.cgi?id=84995. We may to want to change the isElementNode check in enclosingBlock in htmlediting.cpp and instead do it on isBlock and isInline functions.
Attachments
Ryosuke Niwa
Comment 1 2012-05-10 09:42:09 PDT
Makes sense.
Ahmad Saleem
Comment 3 2023-01-24 04:42:44 PST
Ahmad Saleem
Comment 4 2023-01-24 12:12:44 PST
Based on discussion on PR, this change is not required anymore and it does not fix any bug or crash or anything, it might be good change in the past but not anymore. Closing this as "RESOLVED WONTFIX". Thanks!
Note You need to log in before you can comment on or make changes to this bug.