Bug 86106
Summary: | Change isBlock and isInline functions to check for isElementNode | ||
---|---|---|---|
Product: | WebKit | Reporter: | Abhishek Arya <inferno> |
Component: | HTML Editing | Assignee: | Ahmad Saleem <ahmad.saleem792> |
Status: | RESOLVED WONTFIX | ||
Severity: | Normal | CC: | ahmad.saleem792, darin, enrica, inferno, rniwa |
Priority: | P2 | Keywords: | BlinkMergeCandidate |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Abhishek Arya
This came up in discussion on bug https://bugs.webkit.org/show_bug.cgi?id=84995.
We may to want to change the isElementNode check in enclosingBlock in htmlediting.cpp and instead do it on isBlock and isInline functions.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Makes sense.
Ahmad Saleem
Fixed here - https://chromium.googlesource.com/chromium/blink/+/6415003fe8070545c67d82f88c69512bd38b2f9f
Ahmad Saleem
PR - https://github.com/WebKit/WebKit/pull/9034
Ahmad Saleem
Based on discussion on PR, this change is not required anymore and it does not fix any bug or crash or anything, it might be good change in the past but not anymore. Closing this as "RESOLVED WONTFIX". Thanks!