Bug 86096 – [BlackBerry] Assertions and assumptions in BackingStoreClient around m_frame and m_frame->view() are invalid

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Antonio Gomes]

George Staikos 2012-05-06 23:04:05 EDT

This is an interesting bug.  


IntPoint BackingStoreClient::scrollPosition() const
{    ASSERT(m_frame);
    return m_frame->view()->scrollPosition() -
pointToSize(m_frame->view()->mini
mumScrollPosition());
}


m_frame->view() is null.  m_frame is in the middle of construction and is
trying to create its view but malloc is blocked on a mutex.  Meanwhile the test
driver, which runs in the Plaid Zone in terms of speed, is already pinch
zooming the page.

Realistically no user can ever hit this. 

In actuality, the assertions in backingstoreclient are wrong and need to be
fixed.  at a minimum, m_frame->view() can be null or invalid, and perhaps
m_frame can be too.

Adam / Antonio please fix in all branches.

[Antonio Gomes]

Created attachment 141163 [details]
(committed r116657, r=rbuis) Patch

[Rob Buis]

Comment on attachment 141163 [details]
(committed r116657, r=rbuis) Patch

LGTM.

[Antonio Gomes]

Comment on attachment 141163 [details]
(committed r116657, r=rbuis) Patch

Committed r116657.