Bug 86089

Summary: [Qt] Rename QDeclarative* to QQml*
Product: WebKit Reporter: Kent Hansen <kent.hansen>
Component: New BugsAssignee: Kent Hansen <kent.hansen>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, menard, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kent Hansen
Reported 2012-05-10 05:27:13 PDT
[Qt] Rename QDeclarative* to QQml*
Attachments
Patch (27.09 KB, patch)
2012-05-10 05:29 PDT, Kent Hansen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Hansen
Comment 1 2012-05-10 05:29:05 PDT
Created attachment 141153 [details] Patch
WebKit Review Bot
Comment 2 2012-05-10 05:33:02 PDT
Attachment 141153 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1336: QQuickWebViewExperimental::schemeDelegates_At is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1344: QQuickWebViewExperimental::schemeDelegates_Append is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1356: QQuickWebViewExperimental::schemeDelegates_Count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1361: QQuickWebViewExperimental::schemeDelegates_Clear is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:309: schemeDelegates_At is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:310: schemeDelegates_Append is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:311: schemeDelegates_Count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:312: schemeDelegates_Clear is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 8 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Hausmann
Comment 3 2012-05-10 05:34:17 PDT
Comment on attachment 141153 [details] Patch r=me, but let's wait for the EWS to give green lights before landing this.
WebKit Review Bot
Comment 4 2012-05-10 08:11:54 PDT
Comment on attachment 141153 [details] Patch Clearing flags on attachment: 141153 Committed r116646: <http://trac.webkit.org/changeset/116646>
WebKit Review Bot
Comment 5 2012-05-10 08:11:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.