Summary: | Move resumeAnimations to use Internals interface | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Component: | Tools / Tests | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, rakuco, roger_fong, tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gyuyoung Kim
2012-05-10 00:21:39 PDT
Created attachment 141106 [details]
Patch
Comment on attachment 141106 [details] Patch Attachment 141106 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12664261 Created attachment 141128 [details]
Patch
Comment on attachment 141128 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141128&action=review > Source/WebKit/mac/WebKit.order:-1224 > --[WebFrame(WebPrivate) _resumeAnimations] There is no need to update these order files. No harm either. > Source/WebKit/mac/WebView/WebFramePrivate.h:-111 > -// Suspend and resume animations (includes both CSS transitions and CSS animations). > -- (void)_resumeAnimations; It's always scary to remove anything from *Private.h files - functions in these can be used by Apple software. I verified that this change is OK to the extent possible. (In reply to comment #4) > (From update of attachment 141128 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141128&action=review > > > Source/WebKit/mac/WebKit.order:-1224 > > --[WebFrame(WebPrivate) _resumeAnimations] > > There is no need to update these order files. No harm either. > > > Source/WebKit/mac/WebView/WebFramePrivate.h:-111 > > -// Suspend and resume animations (includes both CSS transitions and CSS animations). > > -- (void)_resumeAnimations; > > It's always scary to remove anything from *Private.h files - functions in these can be used by Apple software. I verified that this change is OK to the extent possible. I will take care it when submitting patch further. Thank you for your review. Comment on attachment 141128 [details] Patch Clearing flags on attachment: 141128 Committed r116729: <http://trac.webkit.org/changeset/116729> All reviewed patches have been landed. Closing bug. This patch changed API that was being used by other apps, which consequently now causes these other apps to fail. Please be more careful in the future when making such changes. |