Bug 86047

Summary: JIT memory allocator is not returning memory to the OS on Darwin
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
ggaren: review+
improvement ggaren: review+

Filip Pizlo
Reported 2012-05-09 17:39:43 PDT
Patch forthcoming.
Attachments
the patch (1.83 KB, patch)
2012-05-09 17:41 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
improvement (1.50 KB, patch)
2012-05-11 15:30 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-05-09 17:40:30 PDT
<rdar://problem/11414948>
Filip Pizlo
Comment 2 2012-05-09 17:41:57 PDT
Created attachment 141065 [details] the patch
Geoffrey Garen
Comment 3 2012-05-09 17:43:25 PDT
Comment on attachment 141065 [details] the patch r=me
WebKit Review Bot
Comment 4 2012-05-09 17:44:34 PDT
Attachment 141065 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:93: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 5 2012-05-09 18:32:44 PDT
Landed with style fixes in http://trac.webkit.org/changeset/116593
Filip Pizlo
Comment 6 2012-05-11 15:29:42 PDT
This cam be made a bit safer. Will post an improvement patch shortly.
Filip Pizlo
Comment 7 2012-05-11 15:30:59 PDT
Created attachment 141509 [details] improvement
Geoffrey Garen
Comment 8 2012-05-11 15:33:22 PDT
Comment on attachment 141509 [details] improvement r=me
Filip Pizlo
Comment 9 2012-05-11 15:36:35 PDT
Additional fix landed in http://trac.webkit.org/changeset/116813
Note You need to log in before you can comment on or make changes to this bug.