Bug 86046

Summary:

[Chromium] WebFrameTest.ChromePageNoJavascript isn't catching regressions

Product:

WebKit

Reporter:

Charles Reis <creis>

Component:

Tools / Tests

Assignee:

Thomas Sepez <tsepez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, creis, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch containing revised test.	none

Charles Reis

Reported 2012-05-09 17:28:04 PDT

The ChromePageNoJavascript test in Source/WebKit/chromium/tests/WebFrameTest.cpp is trying to verify that content injected into the DOM isn't showing up because it's a Chrome page. However, the injected content currently wouldn't be detected even if Chrome URLs were allowed to run JavaScript. There needs to be a webView->layout() call before calling contentsAsText in order to catch it.

Attachments
Patch containing revised test. (2.93 KB, patch) 2012-05-10 11:20 PDT, Thomas Sepez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Thomas Sepez

Comment 1 2012-05-10 11:20:19 PDT

Created attachment 141202 [details] Patch containing revised test.

WebKit Review Bot

Comment 2 2012-05-10 14:13:29 PDT

Comment on attachment 141202 [details] Patch containing revised test. Clearing flags on attachment: 141202 Committed r116686: <http://trac.webkit.org/changeset/116686>

WebKit Review Bot

Comment 3 2012-05-10 14:13:34 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.