Bug 86041

Summary: [Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, johnme, peter, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch none

Description Adam Barth 2012-05-09 17:12:05 PDT
[Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
Comment 1 Adam Barth 2012-05-09 17:12:32 PDT
Created attachment 141059 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-09 17:15:04 PDT
Comment on attachment 141059 [details]
Patch

Why?
Comment 3 Adam Barth 2012-05-09 17:36:10 PDT
Comment on attachment 141059 [details]
Patch

I'm not sure.  One possibility to just to reduce the binary size of DRT.  I found the patch in the downstream OS(ANDROID) repository and it seemed harmless to upstream.
Comment 4 WebKit Review Bot 2012-05-09 17:55:32 PDT
Comment on attachment 141059 [details]
Patch

Clearing flags on attachment: 141059

Committed r116589: <http://trac.webkit.org/changeset/116589>
Comment 5 WebKit Review Bot 2012-05-09 17:55:38 PDT
All reviewed patches have been landed.  Closing bug.