Summary: | REGRESSION(r116573): Broke the Chromium Mac compile (Requested by ojan_gardening on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | New Bugs | Assignee: | WebKit Review Bot <webkit.review.bot> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fishd, fsamuel, ojan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 85916 | ||||||
Attachments: |
|
Description
WebKit Review Bot
2012-05-09 16:50:52 PDT
Created attachment 141051 [details] ROLLOUT of r116573 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. In file included from webkit/plugins/webview_plugin.cc:5: ./webkit/plugins/webview_plugin.h:65:31: error: 'webkit::WebViewPlugin::container' hides overloaded virtual function [-Werror,-Woverloaded-virtual] WebKit::WebPluginContainer* container() { return container_; } ^ ./third_party/WebKit/Source/WebKit/chromium/public/WebPlugin.h:59:33: note: hidden overloaded virtual function 'WebKit::WebPlugin::container' declared here virtual WebPluginContainer* container() const { return 0; } ^ 1 error generated. make: *** [out/Release/obj.target/glue/webkit/plugins/webview_plugin.o] Error 1 Comment on attachment 141051 [details] ROLLOUT of r116573 Clearing flags on attachment: 141051 Committed r116582: <http://trac.webkit.org/changeset/116582> All reviewed patches have been landed. Closing bug. |