Bug 86038

Summary: REGRESSION(r116573): Broke the Chromium Mac compile (Requested by ojan_gardening on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, fsamuel, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85916    
Attachments:
Description Flags
ROLLOUT of r116573 none

WebKit Review Bot
Reported 2012-05-09 16:50:52 PDT
http://trac.webkit.org/changeset/116573 broke the build: Broke the Chromium Mac compile (Requested by ojan_gardening on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r116573 (1.34 KB, patch)
2012-05-09 16:51 PDT, WebKit Review Bot
no flags
WebKit Review Bot
Comment 1 2012-05-09 16:51:48 PDT
Created attachment 141051 [details] ROLLOUT of r116573 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Ojan Vafai
Comment 2 2012-05-09 16:53:07 PDT
In file included from webkit/plugins/webview_plugin.cc:5: ./webkit/plugins/webview_plugin.h:65:31: error: 'webkit::WebViewPlugin::container' hides overloaded virtual function [-Werror,-Woverloaded-virtual] WebKit::WebPluginContainer* container() { return container_; } ^ ./third_party/WebKit/Source/WebKit/chromium/public/WebPlugin.h:59:33: note: hidden overloaded virtual function 'WebKit::WebPlugin::container' declared here virtual WebPluginContainer* container() const { return 0; } ^ 1 error generated. make: *** [out/Release/obj.target/glue/webkit/plugins/webview_plugin.o] Error 1
WebKit Review Bot
Comment 3 2012-05-09 17:17:38 PDT
Comment on attachment 141051 [details] ROLLOUT of r116573 Clearing flags on attachment: 141051 Committed r116582: <http://trac.webkit.org/changeset/116582>
WebKit Review Bot
Comment 4 2012-05-09 17:17:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.