Bug 86028

Summary: Don't append log lines while perf tests are running.
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Tony Chang
Reported 2012-05-09 16:01:11 PDT
Don't append log lines while perf tests are running.
Attachments
Patch (2.40 KB, patch)
2012-05-09 16:03 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.36 KB, patch)
2012-05-14 10:00 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.34 KB, patch)
2012-05-14 11:53 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-05-09 16:03:26 PDT
Created attachment 141039 [details] Patch
Tony Chang
Comment 2 2012-05-11 10:59:48 PDT
ping ryosuke
Ryosuke Niwa
Comment 3 2012-05-11 21:53:31 PDT
Comment on attachment 141039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141039&action=review We've started adding tests in http://trac.webkit.org/browser/trunk/LayoutTests/fast/harness/perftests not that I think we should add a test for this. > PerformanceTests/resources/runner.js:171 > + this._showLogLinesAtEndOfTest = !!window.layoutTestController; > + this._logLines = []; We can just do: this._logLines = window.layoutTestController ? [] : undefined; That way, we don't need _showLogLinesAtEndOfTest.
Tony Chang
Comment 4 2012-05-14 10:00:46 PDT
Created attachment 141746 [details] Patch for landing
Tony Chang
Comment 5 2012-05-14 10:01:20 PDT
(In reply to comment #3) > (From update of attachment 141039 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141039&action=review > > > PerformanceTests/resources/runner.js:171 > > + this._showLogLinesAtEndOfTest = !!window.layoutTestController; > > + this._logLines = []; > > We can just do: > this._logLines = window.layoutTestController ? [] : undefined; > That way, we don't need _showLogLinesAtEndOfTest. Good idea, done.
Ryosuke Niwa
Comment 6 2012-05-14 11:05:06 PDT
Comment on attachment 141746 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=141746&action=review > PerformanceTests/resources/runner.js:183 > + this._logLines = window.layoutTestController ? [] : null; Oh you probably need to do this in initAndStartLoop instead because now we have runPerSecond.
Tony Chang
Comment 7 2012-05-14 11:53:19 PDT
Created attachment 141763 [details] Patch for landing
WebKit Review Bot
Comment 8 2012-05-14 12:28:04 PDT
Comment on attachment 141763 [details] Patch for landing Clearing flags on attachment: 141763 Committed r116984: <http://trac.webkit.org/changeset/116984>
WebKit Review Bot
Comment 9 2012-05-14 12:28:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.