Summary: | Don't append log lines while perf tests are running. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||||
Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ojan, rniwa, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 77037 | ||||||||||
Attachments: |
|
Description
Tony Chang
2012-05-09 16:01:11 PDT
Created attachment 141039 [details]
Patch
ping ryosuke Comment on attachment 141039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141039&action=review We've started adding tests in http://trac.webkit.org/browser/trunk/LayoutTests/fast/harness/perftests not that I think we should add a test for this. > PerformanceTests/resources/runner.js:171 > + this._showLogLinesAtEndOfTest = !!window.layoutTestController; > + this._logLines = []; We can just do: this._logLines = window.layoutTestController ? [] : undefined; That way, we don't need _showLogLinesAtEndOfTest. Created attachment 141746 [details]
Patch for landing
(In reply to comment #3) > (From update of attachment 141039 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141039&action=review > > > PerformanceTests/resources/runner.js:171 > > + this._showLogLinesAtEndOfTest = !!window.layoutTestController; > > + this._logLines = []; > > We can just do: > this._logLines = window.layoutTestController ? [] : undefined; > That way, we don't need _showLogLinesAtEndOfTest. Good idea, done. Comment on attachment 141746 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=141746&action=review > PerformanceTests/resources/runner.js:183 > + this._logLines = window.layoutTestController ? [] : null; Oh you probably need to do this in initAndStartLoop instead because now we have runPerSecond. Created attachment 141763 [details]
Patch for landing
Comment on attachment 141763 [details] Patch for landing Clearing flags on attachment: 141763 Committed r116984: <http://trac.webkit.org/changeset/116984> All reviewed patches have been landed. Closing bug. |