Summary: | Remove some isSVGFoo methods | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rob Buis <rwlbuis> | ||||
Component: | SVG | Assignee: | Rob Buis <rwlbuis> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, pdr, webkit.review.bot, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Rob Buis
2012-05-09 12:45:02 PDT
Created attachment 141000 [details]
Patch
I would give this a R+ if I could. Comment on attachment 141000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141000&action=review > Source/WebCore/rendering/svg/RenderSVGEllipse.h:-42 > - virtual bool isSVGEllipse() const { return true; } Is there one of these on teh base class as well? Hi Eric, Thanks for the review! (In reply to comment #3) > (From update of attachment 141000 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141000&action=review > > > Source/WebCore/rendering/svg/RenderSVGEllipse.h:-42 > > - virtual bool isSVGEllipse() const { return true; } > > Is there one of these on teh base class as well? Nope, there was a mention of isSVGRect in RenderObject.h but not isSVGEllipse, a sure sign that some of these flags got inconsistent. Comment on attachment 141000 [details] Patch Clearing flags on attachment: 141000 Committed r116557: <http://trac.webkit.org/changeset/116557> All reviewed patches have been landed. Closing bug. |