Bug 86009

Summary: Remove some isSVGFoo methods
Product: WebKit Reporter: Rob Buis <rwlbuis@gmail.com>
Component: SVGAssignee: Rob Buis <rwlbuis@gmail.com>
Status: RESOLVED FIXED    
Severity: Normal CC: eric@webkit.org, pdr@google.com, webkit.review.bot@gmail.com, zimmermann@kde.org
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description From 2012-05-09 12:45:02 PST
Stuff like isRounded() is not needed at all atm.
------- Comment #1 From 2012-05-09 12:49:58 PST -------
Created an attachment (id=141000) [details]
Patch
------- Comment #2 From 2012-05-09 13:06:30 PST -------
I would give this a R+ if I could.
------- Comment #3 From 2012-05-09 13:18:06 PST -------
(From update of attachment 141000 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=141000&action=review

> Source/WebCore/rendering/svg/RenderSVGEllipse.h:-42
> -    virtual bool isSVGEllipse() const { return true; }

Is there one of these on teh base class as well?
------- Comment #4 From 2012-05-09 13:21:33 PST -------
Hi Eric,

Thanks for the review!

(In reply to comment #3)
> (From update of attachment 141000 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141000&action=review
> 
> > Source/WebCore/rendering/svg/RenderSVGEllipse.h:-42
> > -    virtual bool isSVGEllipse() const { return true; }
> 
> Is there one of these on teh base class as well?

Nope, there was a mention of isSVGRect in RenderObject.h but not isSVGEllipse, a sure sign that some of these flags got inconsistent.
------- Comment #5 From 2012-05-09 14:19:25 PST -------
(From update of attachment 141000 [details])
Clearing flags on attachment: 141000

Committed r116557: <http://trac.webkit.org/changeset/116557>
------- Comment #6 From 2012-05-09 14:19:30 PST -------
All reviewed patches have been landed.  Closing bug.