Bug 85988

Summary: MediaStream API: SessionDescription::addCandidate should not crash for malformed input
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 80589    
Attachments:
Description Flags
Patch none

Tommy Widenflycht
Reported 2012-05-09 05:45:04 PDT
Sending null would crash the browser. Added safeguards in both the bindings and the native code.
Attachments
Patch (6.50 KB, patch)
2012-05-09 05:50 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-05-09 05:50:00 PDT
Created attachment 140928 [details] Patch
Adam Barth
Comment 2 2012-05-09 08:02:59 PDT
Comment on attachment 140928 [details] Patch I support not crashing. :)
WebKit Review Bot
Comment 3 2012-05-09 08:55:16 PDT
Comment on attachment 140928 [details] Patch Clearing flags on attachment: 140928 Committed r116530: <http://trac.webkit.org/changeset/116530>
WebKit Review Bot
Comment 4 2012-05-09 08:55:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.