Bug 85988 - MediaStream API: SessionDescription::addCandidate should not crash for malformed input
Summary: MediaStream API: SessionDescription::addCandidate should not crash for malfor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 80589
  Show dependency treegraph
 
Reported: 2012-05-09 05:45 PDT by Tommy Widenflycht
Modified: 2012-05-09 08:55 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.50 KB, patch)
2012-05-09 05:50 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-05-09 05:45:04 PDT
Sending null would crash the browser. Added safeguards in both the bindings and the native code.
Comment 1 Tommy Widenflycht 2012-05-09 05:50:00 PDT
Created attachment 140928 [details]
Patch
Comment 2 Adam Barth 2012-05-09 08:02:59 PDT
Comment on attachment 140928 [details]
Patch

I support not crashing.  :)
Comment 3 WebKit Review Bot 2012-05-09 08:55:16 PDT
Comment on attachment 140928 [details]
Patch

Clearing flags on attachment: 140928

Committed r116530: <http://trac.webkit.org/changeset/116530>
Comment 4 WebKit Review Bot 2012-05-09 08:55:21 PDT
All reviewed patches have been landed.  Closing bug.