Bug 85986

Summary: Move suspendAnimations to use Internals interface
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, rakuco, rniwa, roger_fong, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Gyuyoung Kim 2012-05-09 05:33:51 PDT 
Adjust suspendAnimations() tests to use Internals instead of LayoutTestController interface. It seems to me that suspendAnimations() is able to be supported by Internals. Because, it looks this function is implemented by WebCore layer, not WebKit layer. If this patch is valid, I'm going to submit a patch for resumeAnimations() as well.
Comment 1 Gyuyoung Kim 2012-05-09 05:43:44 PDT 
Created attachment 140927 [details]
Patch
Comment 2 Build Bot 2012-05-09 06:10:40 PDT 
Comment on attachment 140927 [details]
Patch

Attachment 140927 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12642907
Comment 3 Gyuyoung Kim 2012-05-09 07:03:43 PDT 
Created attachment 140936 [details]
Patch
Comment 4 Gyuyoung Kim 2012-05-09 21:34:37 PDT 
CC'ing Ryosuke, Alexey
Comment 5 WebKit Review Bot 2012-05-09 23:10:43 PDT 
Comment on attachment 140936 [details]
Patch

Clearing flags on attachment: 140936

Committed r116610: <http://trac.webkit.org/changeset/116610>
Comment 6 WebKit Review Bot 2012-05-09 23:10:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Roger Fong 2012-07-17 17:07:32 PDT 
This patch changed API that was being used by other apps, which consequently now causes these other apps to fail. Please be more careful in the future when making such changes.
Comment 8 Ryosuke Niwa 2012-07-17 18:23:07 PDT 
(In reply to comment #7)
> This patch changed API that was being used by other apps, which consequently now causes these other apps to fail. Please be more careful in the future when making such changes.

Could you add a message rule on Source/WebKit/win/WebFrame.h
to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/watchlist ?

e.g. see AppleMacPublicApi
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/watchlist#L262

It wasn't obvious that this was a part of public API.
Comment 9 Gyuyoung Kim 2012-07-17 19:54:30 PDT 
(In reply to comment #7)
> This patch changed API that was being used by other apps, which consequently now causes these other apps to fail. Please be more careful in the future when making such changes.

There was similar problem in Bug 86704. I have tried to be more careful since the bug. Sorry for making inconvenience.