Summary: | [chromium] Exposes OrientationChangeEvent. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Marcus Bulach <bulach> | ||||||
Component: | New Bugs | Assignee: | Marcus Bulach <bulach> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Marcus Bulach
2012-05-09 03:40:59 PDT
Created attachment 140906 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 140906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140906&action=review > Source/WebKit/chromium/public/WebFrame.h:570 > + virtual void sendOrientationChangeEvent(int orientation) = 0; This comment from Frame.h was helpful to me. I wonder if we should include it here too: // Orientation is the interface orientation in degrees. Some examples are: // 0 is straight up; -90 is when the device is rotated 90 clockwise; // 90 is when rotated counter clockwise. Created attachment 140960 [details]
Patch
Comment on attachment 140960 [details]
Patch
Many thanks.
Comment on attachment 140906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140906&action=review >> Source/WebKit/chromium/public/WebFrame.h:570 >> + virtual void sendOrientationChangeEvent(int orientation) = 0; > > This comment from Frame.h was helpful to me. I wonder if we should include it here too: > > // Orientation is the interface orientation in degrees. Some examples are: > // 0 is straight up; -90 is when the device is rotated 90 clockwise; > // 90 is when rotated counter clockwise. yeah, agreed it clarifies. added. Comment on attachment 140960 [details] Patch Clearing flags on attachment: 140960 Committed r116544: <http://trac.webkit.org/changeset/116544> All reviewed patches have been landed. Closing bug. |