Summary: | [GTK] don't use soup_session_pause_message in webkitdownload | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dan Winship <danw> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dan Winship
2012-05-08 16:46:05 PDT
Created attachment 140815 [details]
patch
Hm... prepare-ChangeLog didn't add the "No new tests. (OOPS!)" line... I guess we get a pass because it's platform-specific code? Still, a test would be nice.
Comment on attachment 140815 [details]
patch
Looks good to me. setDefersLoading is tested by the layout tests, but an option if you want to add a test is to add a GTK+ API unit test.
Comment on attachment 140815 [details]
patch
ok, actually testmimehandling was already broken against libsoup master without this patch, and now works again with this patch
Comment on attachment 140815 [details] patch Clearing flags on attachment: 140815 Committed r116525: <http://trac.webkit.org/changeset/116525> All reviewed patches have been landed. Closing bug. |