Bug 85928

Summary:

[JSC] Regression: addEventListener() and removeEventListener() raise an exception on missing args

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

WebCore JavaScript

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ddkilzer, haraken, japhet, mjs, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+

Description Benjamin Poulain 2012-05-08 16:24:47 PDT

addEventListener() and removeEventListener() raise an exception on missing args following:
-https://bugs.webkit.org/show_bug.cgi?id=62750
-https://bugs.webkit.org/show_bug.cgi?id=71489
-https://bugs.webkit.org/show_bug.cgi?id=71503

This breaks content.

Comment 1 Benjamin Poulain 2012-05-08 16:39:00 PDT

Created attachment 140812 [details]
Patch

Comment 2 Geoffrey Garen 2012-05-08 16:40:25 PDT

Comment on attachment 140812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140812&action=review

r=me

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2122
> +                    # For compatibility with legacy content, the EventListener call are generated without GenerateArgumentsCountCheck.

Typo: should be "calls".

Comment 3 Benjamin Poulain 2012-05-08 20:19:30 PDT

Committed r116486: <http://trac.webkit.org/changeset/116486>

Comment 4 Benjamin Poulain 2012-05-08 20:24:51 PDT

<rdar://problem/11092785>