Bug 85928

Summary: [JSC] Regression: addEventListener() and removeEventListener() raise an exception on missing args
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebCore JavaScriptAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ddkilzer, haraken, japhet, mjs, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Benjamin Poulain
Reported 2012-05-08 16:24:47 PDT
addEventListener() and removeEventListener() raise an exception on missing args following: -https://bugs.webkit.org/show_bug.cgi?id=62750 -https://bugs.webkit.org/show_bug.cgi?id=71489 -https://bugs.webkit.org/show_bug.cgi?id=71503 This breaks content.
Attachments
Patch (10.42 KB, patch)
2012-05-08 16:39 PDT, Benjamin Poulain 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-05-08 16:39:00 PDT
Created attachment 140812 [details] Patch
Geoffrey Garen
Comment 2 2012-05-08 16:40:25 PDT
Comment on attachment 140812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140812&action=review r=me > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2122 > + # For compatibility with legacy content, the EventListener call are generated without GenerateArgumentsCountCheck. Typo: should be "calls".
Benjamin Poulain
Comment 3 2012-05-08 20:19:30 PDT
Committed r116486: <http://trac.webkit.org/changeset/116486>
Benjamin Poulain
Comment 4 2012-05-08 20:24:51 PDT
<rdar://problem/11092785>
Note You need to log in before you can comment on or make changes to this bug.