| Summary: | [chromium] Reflections with masks should not occlude | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dana Jansens <danakj> | ||||||
| Component: | New Bugs | Assignee: | Dana Jansens <danakj> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | backer, cc-bugs, enne, jamesr, piman, vangelis, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Dana Jansens
2012-05-08 15:54:28 PDT
Created attachment 140804 [details]
Patch
Comment on attachment 140804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140804&action=review > Source/WebCore/ChangeLog:16 > + allow us to remove a F*XME from CCOT::finishedTargetRenderSurface(). F*XME? could you expand out CCOT here, please? it's not necessarily obvious to a reader how this acronym should expand. you can also put this comment in the per-file or per-function information below so the context is obvious (In reply to comment #3) > (From update of attachment 140804 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140804&action=review > > > Source/WebCore/ChangeLog:16 > > + allow us to remove a F*XME from CCOT::finishedTargetRenderSurface(). > > F*XME? > > could you expand out CCOT here, please? it's not necessarily obvious to a reader how this acronym should expand. you can also put this comment in the per-file or per-function information below so the context is obvious Oops, yes, too much coffee. Thanks. Created attachment 140813 [details]
Patch for landing
Comment on attachment 140813 [details] Patch for landing Clearing flags on attachment: 140813 Committed r116472: <http://trac.webkit.org/changeset/116472> All reviewed patches have been landed. Closing bug. |