Bug 85858

Summary: Change the return type of Entry.toURL() back to String from KURL
Product: WebKit Reporter: Kinuko Yasuda <kinuko>
Component: WebCore Misc.Assignee: Kinuko Yasuda <kinuko>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kinuko Yasuda
Reported 2012-05-07 21:40:23 PDT
Change the return type of Entry.toURL() back to String from KURL. I once changed it from String to KURL in https://bugs.webkit.org/show_bug.cgi?id=85736 but it turned out that it needs implicit conversion and could incur an extra overhead.
Attachments
Patch (5.90 KB, patch)
2012-05-07 21:44 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (5.90 KB, patch)
2012-05-07 21:55 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (2.60 KB, patch)
2012-05-07 23:51 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2012-05-07 21:44:11 PDT
Created attachment 140668 [details] Patch
Kinuko Yasuda
Comment 2 2012-05-07 21:55:16 PDT
Created attachment 140669 [details] Patch
WebKit Review Bot
Comment 3 2012-05-07 22:46:40 PDT
Comment on attachment 140669 [details] Patch Attachment 140669 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12643550
Kinuko Yasuda
Comment 4 2012-05-07 23:51:12 PDT
Created attachment 140682 [details] Patch
Ryosuke Niwa
Comment 5 2012-05-10 01:03:37 PDT
Comment on attachment 140682 [details] Patch rs=me.
WebKit Review Bot
Comment 6 2012-05-10 02:58:58 PDT
Comment on attachment 140682 [details] Patch Clearing flags on attachment: 140682 Committed r116623: <http://trac.webkit.org/changeset/116623>
WebKit Review Bot
Comment 7 2012-05-10 02:59:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.