Bug 85806

Summary: WebPageProxy::activeURL() should return the pending API request, even when there's no main frame
Product: WebKit Reporter: Tor Arne Vestbø <vestbo>
Component: New BugsAssignee: Tor Arne Vestbø <vestbo>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77554    
Attachments:
Description Flags
Patch
none
Patch none

Tor Arne Vestbø
Reported 2012-05-07 10:23:53 PDT
WebPageProxy::activeURL() should return the pending API request, even when there's no main frame
Attachments
Patch (2.99 KB, patch)
2012-05-07 10:32 PDT, Tor Arne Vestbø 		no flags
DetailsFormatted DiffDiff
Patch (4.94 KB, patch)
2012-05-09 03:02 PDT, Tor Arne Vestbø 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1 2012-05-07 10:32:35 PDT
Created attachment 140546 [details] Patch
Darin Adler
Comment 2 2012-05-08 13:15:13 PDT
Comment on attachment 140546 [details] Patch Sure would be nice to say why this is a good change. The bug title and change log states that this should be done and says nothing about why.
Tor Arne Vestbø
Comment 3 2012-05-09 03:02:28 PDT
Created attachment 140897 [details] Patch
Tor Arne Vestbø
Comment 4 2012-05-09 03:04:43 PDT
(In reply to comment #2) > (From update of attachment 140546 [details]) > Sure would be nice to say why this is a good change. The bug title and change log states that this should be done and says nothing about why. Sorry about that, was having some issues with webkit-patch and failed to fill in the changelog. New patch uploaded.
Simon Hausmann
Comment 5 2012-05-10 03:35:55 PDT
Comment on attachment 140897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140897&action=review > Source/WebKit2/ChangeLog:8 > + immedeatly from activeURL, even if the request has not been passed over to immedeatly -> immediately
Tor Arne Vestbø
Comment 6 2012-05-10 10:14:00 PDT
Landed with fleshed out changelog in r116626
Note You need to log in before you can comment on or make changes to this bug.